Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalized no-goto-without-base into no-navigation-without-base #900

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Generalized no-goto-without-base into no-navigation-without-base #900

wants to merge 11 commits into from

Conversation

marekdedic
Copy link
Contributor

Closes #891

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: add6e9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marekdedic marekdedic force-pushed the no-navigation-without-base branch 10 times, most recently from daa932b to 8a9a43d Compare November 3, 2024 23:52
@marekdedic marekdedic marked this pull request as ready for review November 4, 2024 00:13
ota-meshi
ota-meshi requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Thank you for implementing the useful rule!

packages/eslint-plugin-svelte/src/rules/no-navigation-without-base.ts Outdated Show resolved Hide resolved
@marekdedic marekdedic force-pushed the no-navigation-without-base branch 2 times, most recently from 1b9b252 to 4676b96 Compare November 30, 2024 09:27
@marekdedic marekdedic requested a review from ota-meshi November 30, 2024 09:32
@ota-meshi
Copy link
Member

ota-meshi commented Dec 2, 2024 •
edited
Loading

This PR is looks good, but I made this package ESM.
#932

Could you please merge the main branch and fix it by adding .js to the import statement of your implementation?

@marekdedic marekdedic force-pushed the no-navigation-without-base branch from 4676b96 to 9ccfe71 Compare December 2, 2024 10:50
@marekdedic
chore: duplicated no-goto-without-base into no-navigation-without-base
7d92cd5
@marekdedic
chore: deprecated the no-goto-without-base rule
394acc5
@marekdedic
test(no-navigation-without-base): added test for pushState, replaceSt…
2a03e88 
…ate and links
@marekdedic
feat(no-navigation-without-base): added support for pushState and rep…
df96f99 
…laceState
@marekdedic
feat(no-navigation-without-base): added support for links
67e9884
@marekdedic
feat(no-navigation-without-base): added configuration options
d14664a
@marekdedic
docs(no-navigation-without-base): documented the new rule
8e587e1
@marekdedic
feat(no-navigation-without-base): added support for urls defined in v…
84c133a 
…ariables
@marekdedic
chore(no-navigation-without-base): added changesets
6aa1bb7
@marekdedic
test(no-navigation-without-base): added namespace import tests
ea788db
@marekdedic
fix(no-navigation-without-base): fixed namespace import detections
add6e9b
@marekdedic marekdedic force-pushed the no-navigation-without-base branch from 9ccfe71 to add6e9b Compare December 2, 2024 11:00
@marekdedic
Copy link
Contributor Author

@ota-meshi Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi Awaiting requested review from ota-meshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rule no-link-without-base
2 participants
@marekdedic @ota-meshi